]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
regmap: Fix possible shift overflow in regmap_field_init()
authorMaxime Coquelin <maxime.coquelin@st.com>
Tue, 16 Jun 2015 11:53:19 +0000 (13:53 +0200)
committerSasha Levin <sasha.levin@oracle.com>
Sat, 4 Jul 2015 03:02:31 +0000 (23:02 -0400)
commitc00a686169ade8556ca010eb5bad6d9b6d4503cb
treef6d97701669fb21b9effc77bd32351c4129a734a
parentf099f4aaad04c7fa3f3001796d03f3754e64e748
regmap: Fix possible shift overflow in regmap_field_init()

[ Upstream commit 921cc29473a0d7c109105c1876ddb432f4a4be7d ]

The way the mask is generated in regmap_field_init() is wrong.
Indeed, a field initialized with msb = 31 and lsb = 0 provokes a shift
overflow while calculating the mask field.

On some 32 bits architectures, such as x86, the generated mask is 0,
instead of the expected 0xffffffff.

This patch uses GENMASK() to fix the problem, as this macro is already safe
regarding shift overflow.

Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/base/regmap/regmap.c