]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sctp: add vtag check in sctp_sf_violation
authorXin Long <lucien.xin@gmail.com>
Wed, 20 Oct 2021 11:42:45 +0000 (07:42 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Nov 2021 16:38:12 +0000 (17:38 +0100)
commitc0b5302e3a74997b57985b561e776269d1951ac7
treef20b3731ea9b74f3e3fe999d1d93c4dc146b31bd
parent629d2823abf957bcbcba32154f1f6fd49bdb850c
sctp: add vtag check in sctp_sf_violation

[ Upstream commit aa0f697e45286a6b5f0ceca9418acf54b9099d99 ]

sctp_sf_violation() is called when processing HEARTBEAT_ACK chunk
in cookie_wait state, and some other places are also using it.

The vtag in the chunk's sctphdr should be verified, otherwise, as
later in chunk length check, it may send abort with the existent
asoc's vtag, which can be exploited by one to cook a malicious
chunk to terminate a SCTP asoc.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sctp/sm_statefuns.c