]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: qla2xxx: Completely fix fcport double free
authorVladimir Riabchun <ferr.lambarginio@gmail.com>
Tue, 10 Feb 2026 10:08:22 +0000 (11:08 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 7 Mar 2026 16:12:46 +0000 (11:12 -0500)
commitc0b7da13a04bd70ef6070bfb9ea85f582294560a
treea6ec097974ebfc4578c0813d08360568a9553533
parentb0bd84c39289ef6a6c3827dd52c875659291970a
scsi: qla2xxx: Completely fix fcport double free

In qla24xx_els_dcmd_iocb() sp->free is set to qla2x00_els_dcmd_sp_free().
When an error happens, this function is called by qla2x00_sp_release(),
when kref_put() releases the first and the last reference.

qla2x00_els_dcmd_sp_free() frees fcport by calling qla2x00_free_fcport().
Doing it one more time after kref_put() is a bad idea.

Fixes: 82f522ae0d97 ("scsi: qla2xxx: Fix double free of fcport")
Fixes: 4895009c4bb7 ("scsi: qla2xxx: Prevent command send on chip reset")
Signed-off-by: Vladimir Riabchun <ferr.lambarginio@gmail.com>
Signed-off-by: Farhat Abbas <fabbas@cloudlinux.com>
Link: https://patch.msgid.link/aYsDln9NFQQsPDgg@vova-pc
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_iocb.c