]> git.ipfire.org Git - thirdparty/openssl.git/commit
sm2: sm2_sign.c: check EC_KEY_get0_private_key() for NULL in sm2_sig_gen()
authorAntonMoryakov <ant.v.moryakov@gmail.com>
Mon, 2 Jun 2025 10:14:28 +0000 (13:14 +0300)
committerTomas Mraz <tomas@openssl.org>
Fri, 25 Jul 2025 10:06:54 +0000 (12:06 +0200)
commitc108ead2840a76a59fe02c049d08322a02b24761
tree2453851a8a66dcaa7149ae1c5a0916711e5c921c
parentbd172dd0e1b76116402534aa4bb5c89d039e7762
sm2: sm2_sign.c: check EC_KEY_get0_private_key() for NULL in sm2_sig_gen()

Static analysis revealed that sm2_sig_gen() dereferences the return value
of EC_KEY_get0_private_key() without checking for NULL. This could lead to
a crash if the private key is unset.

This patch adds a NULL check and raises ERR_R_PASSED_NULL_PARAMETER if the
key is missing.

Issue found by static analyzer:
> Return value of EC_KEY_get0_private_key() is dereferenced without checking for NULL (11/12 checked)

CLA: trivial
Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27741)
crypto/sm2/sm2_sign.c