]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Remove special rule for TypeDecorator of TypeDecorator
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 5 Jan 2021 13:48:36 +0000 (08:48 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Wed, 6 Jan 2021 02:56:18 +0000 (21:56 -0500)
commitc12012452e11093a06e3c83c19fe4d794f5bb21e
tree1681e269d80f0e74da7eeb27bd177f967318c601
parent640cd8a70f8a664b7834c5f74ec322fdea644043
Remove special rule for TypeDecorator of TypeDecorator

Removing this check for "TypeDecorator" in impl seems to not
break anything and allows TypeDecorator.with_variant() to
work correctly.   The line has been traced back to 2007 and
does not appear to have relevance today.

Fixed bug where making use of the :meth:`.TypeEngine.with_variant` method
on a :class:`.TypeDecorator` type would fail to take into account the
dialect-specific mappings in use, due to a rule in :class:`.TypeDecorator`
that was instead attempting to check for chains of :class:`.TypeDecorator`
instances.

Fixes: #5816
Change-Id: Ic86d9d985810e3050f15972b4841108acca2fa3e
doc/build/changelog/unreleased_13/5816.rst [new file with mode: 0644]
lib/sqlalchemy/sql/type_api.py
test/sql/test_types.py