]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iio: light: opt3001: fix missing state reset on timeout
authorJoshua Crofts <joshua.crofts1@gmail.com>
Tue, 26 May 2026 11:15:29 +0000 (13:15 +0200)
committerJonathan Cameron <jic23@kernel.org>
Wed, 27 May 2026 11:11:15 +0000 (12:11 +0100)
commitc123ca6ee26ad98f70a866ff428b08145c5a24fe
treec7c5f5e9330328076a46876c94fc32e75b369129
parent60d877910a43c305b5165131b258a17b1d772d57
iio: light: opt3001: fix missing state reset on timeout

Currently in the function opt3001_get_processed(), there is a check
that directly returns -ETIMEDOUT if the conversion IRQ times out,
completely bypassing the err label, leaving ok_to_ignore_lock
permanently true, potentially breaking the device's falling threshold
interrupt detection.

Assign -ETIMEDOUT to the return variable and jump to the error label
to ensure ok_to_ignore_lock is properly reset.

Fixes: 26d90b559057 ("iio: light: opt3001: Fixed timeout error when 0 lux")
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/patchset/20260525-opt3001-cleanup-v4-0-65b36a174f78%40gmail.com?part=1
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/light/opt3001.c