]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
coredump: fix error handling for replace_fd()
authorChristian Brauner <brauner@kernel.org>
Mon, 14 Apr 2025 13:55:06 +0000 (15:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:46:26 +0000 (14:46 +0200)
commitc13640f95bafdfc8bbd6ce1f6949690a85505448
treeae244afbcb47236097965edf1a39e0710e735add
parent24aed3a922a52540ff919b3de0ab020c305e6234
coredump: fix error handling for replace_fd()

commit 95c5f43181fe9c1b5e5a4bd3281c857a5259991f upstream.

The replace_fd() helper returns the file descriptor number on success
and a negative error code on failure. The current error handling in
umh_pipe_setup() only works because the file descriptor that is replaced
is zero but that's pretty volatile. Explicitly check for a negative
error code.

Link: https://lore.kernel.org/20250414-work-coredump-v2-2-685bf231f828@kernel.org
Tested-by: Luca Boccassi <luca.boccassi@gmail.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/coredump.c