]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
arm64: dts: rockchip: Fix UART pull-ups on rk3328
authorChen-Yu Tsai <wens@csie.org>
Fri, 4 Dec 2020 06:48:05 +0000 (14:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:26:00 +0000 (11:26 +0100)
commitc13ad4f26b01805011c90a6680570da2fe159553
tree7d2bfa48235d0bc00ea0a87eb8cf146f4b662879
parent59f9efc349335a8a7b0481627fd6850e722fe523
arm64: dts: rockchip: Fix UART pull-ups on rk3328

[ Upstream commit 94dad6bed3c86c00050bf7c2b2ad6b630facae31 ]

For UARTs, the local pull-ups should be on the RX pin, not the TX pin.
UARTs transmit active-low, so a disconnected RX pin should be pulled
high instead of left floating to prevent noise being interpreted as
transmissions.

This gets rid of bogus sysrq events when the UART console is not
connected.

Fixes: 52e02d377a72 ("arm64: dts: rockchip: add core dtsi file for RK3328 SoCs")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20201204064805.6480-1-wens@kernel.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm64/boot/dts/rockchip/rk3328.dtsi