]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemuDomainObjBeginJob: Don't account DESTROY job to maxQueuedJobs
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 5 Mar 2018 09:13:29 +0000 (10:13 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 7 Mar 2018 11:27:03 +0000 (12:27 +0100)
commitc17666419b3579c9c73b5a49027eaeb999a85689
tree762412d61aaf826804f097ac514ab6055df2ce26
parentb704d60e89bede4dbca7089bbec70b5d48b0dd78
qemuDomainObjBeginJob: Don't account DESTROY job to maxQueuedJobs

When trying to destroy a domain (e.g. because we've seen EOF on
the monitor) we try to acquire QEMU_JOB_DESTROY. However, if
max_queued is set in qemu.conf this may fail and since our code
doesn't count on that we will still report domain as active even
though the qemu process is long gone. More specifically, if we've
seen EOF on the monitor, qemuProcessHandleMonitorEOF() is called
which sends MONITOR_EOF job to the event worker pool and
unregisters monitor from the event loop. The worker pool calls
processMonitorEOFEvent() which tries to set job which may fail
due to the limit as described above.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_domain.c