]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
NFS: Remove rpcbind cleanup for NFSv4.0 callback
authorChuck Lever <chuck.lever@oracle.com>
Wed, 20 Aug 2025 14:27:27 +0000 (10:27 -0400)
committerAnna Schumaker <anna.schumaker@oracle.com>
Tue, 23 Sep 2025 17:28:19 +0000 (13:28 -0400)
commitc231cea10d418c9d2596bcb8f5a06e18b55c1435
tree21bdea4dbb728612855dd17e3c7feb4ab016eedf
parentbf75ad096820fee5da40e671ebb32de725a1c417
NFS: Remove rpcbind cleanup for NFSv4.0 callback

The NFS client's NFSv4.0 callback listeners are created with
SVC_SOCK_ANONYMOUS, therefore svc_setup_socket() does not register
them with the client's rpcbind service.

And, note that nfs_callback_down_net() does not call
svc_rpcb_cleanup() at all when shutting down the callback server.

Even if svc_setup_socket() were to attempt to register or unregister
these sockets, the callback service has vs_hidden set, which shunts
the rpcbind upcalls.

The svc_rpcb_cleanup() error flow was introduced by
commit c946556b8749 ("NFS: move per-net callback thread
initialization to nfs_callback_up_net()"). It doesn't appear in the
code that was relocated by that commit.

Therefore, there is no need to call svc_rpcb_cleanup() when listener
creation fails during callback server start-up.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
fs/nfs/callback.c