]> git.ipfire.org Git - thirdparty/git.git/commit
http-push: stop setting up `the_repository` for each reference
authorPatrick Steinhardt <ps@pks.im>
Wed, 19 Nov 2025 07:50:57 +0000 (08:50 +0100)
committerJunio C Hamano <gitster@pobox.com>
Tue, 25 Nov 2025 20:16:00 +0000 (12:16 -0800)
commitc257bd59165e2f55dfa2c97b0ca1e39131513654
tree71da1a21f99a19e0d3c99e0b5da7bf53a894d76a
parenteea83c010cf431325a05f06cc7c64029538c8495
http-push: stop setting up `the_repository` for each reference

When pushing references via HTTP we call `repo_init_revisions()` in a
loop for each reference that we're about to push. As third argument we
pass the result of `setup_git_directory()`, which causes us to
reinitialize the repository every single time.

This is an obvious waste of compute, as the repository that we're
working in will never change across any of the initializations. The only
reason that we do this is to retrieve the directory of the repository.
Furthermore, this is about to create issues in a subsequent commit,
where reinitializing the repository will cause a `BUG()`.

Address this by storing the Git directory in a variable instead so that
we don't have to call the function repeatedly.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http-push.c