]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: txgbe: fix firmware version check
authorJiawen Wu <jiawenwu@trustnetic.com>
Wed, 22 Apr 2026 07:18:37 +0000 (15:18 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Apr 2026 19:02:59 +0000 (12:02 -0700)
commitc263f644add3d6ad81f9d62a99284fde408f0caa
treea57f321b217330de1c9e0ff4ab20535f8c7d7d78
parent07811361a3d0c59e741a02c8d4613258044a8750
net: txgbe: fix firmware version check

For the device SP, the firmware version is a 32-bit value where the
lower 20 bits represent the base version number. And the customized
firmware version populates the upper 12 bits with a specific
identification number.

For other devices AML 25G and 40G, the upper 12 bits of the firmware
version is always non-zero, and they have other naming conventions.

Only SP devices need to check this to tell if XPCS will work properly.
So the judgement of MAC type is added here.

And the original logic compared the entire 32-bit value against 0x20010,
which caused the outdated base firmwares bypass the version check
without a warning. Apply a mask 0xfffff to isolate the lower 20 bits for
an accurate base version comparison.

Fixes: ab928c24e6cd ("net: txgbe: add FW version warning")
Cc: stable@vger.kernel.org
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/C787AA5C07598B13+20260422071837.372731-1-jiawenwu@trustnetic.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/wangxun/txgbe/txgbe_main.c