]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
team: don't traverse port list using rcu in team_set_mac_address
authorJiri Pirko <jiri@resnulli.us>
Wed, 4 Mar 2015 07:36:31 +0000 (08:36 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 12 Mar 2015 09:06:29 +0000 (10:06 +0100)
commitc272044a55e2df31b31952149f71294615d7e1c3
tree1bb89088e253d31611616286de1b252c49b07844
parent7a763ff1bb18190791d0823996ba0a039268d2cf
team: don't traverse port list using rcu in team_set_mac_address

[ Upstream commit 9215f437b85da339a7dfe3db6e288637406f88b2 ]

Currently the list is traversed using rcu variant. That is not correct
since dev_set_mac_address can be called which eventually calls
rtmsg_ifinfo_build_skb and there, skb allocation can sleep. So fix this
by remove the rcu usage here.

Fixes: 3d249d4ca7 "net: introduce ethernet teaming device"
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/net/team/team.c