]> git.ipfire.org Git - thirdparty/valgrind.git/commit
Memcheck on amd64; fix false positive associated with spec cases {Z,NZ} after {LOGICB...
authorJulian Seward <jseward@acm.org>
Sun, 30 Sep 2018 07:29:43 +0000 (09:29 +0200)
committerJulian Seward <jseward@acm.org>
Sun, 30 Sep 2018 07:29:43 +0000 (09:29 +0200)
commitc2aeea2d28acb0639bcc8cc1e4ab115067db1eae
tree6bc0153a4ebe531b9058b09078382dd8f3586d4f
parent28b6496ee4cb5ec9221d9f231e63c1d00cb6a5ea
Memcheck on amd64; fix false positive associated with spec cases {Z,NZ} after {LOGICB,LOGICW}.  n-i-bz.

For the spec cases {Z,NZ} after {LOGICB,LOGICW}, which are simply comparisons
of the result against zero, use Cmp{EQ,NE}32 rather than their 64-bit
counterparts.  This is because Memcheck on amd64 instruments the 32 bit
versions exactly, at the default --expensive-definedness-checks=auto setting.
The alternative would have been to make Memcheck also do exact instrumentation
of the 64 bit versions, but that would also burden all other 64 bit eq/ne
comparisons with that cost for no purpose.  So this is a cheaper solution.
VEX/priv/guest_amd64_helpers.c