]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Relax overly strict assertion
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 12 Feb 2019 21:42:37 +0000 (18:42 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 12 Feb 2019 21:42:37 +0000 (18:42 -0300)
commitc2e0954be36390f06e1a8821921648bc258c38bf
treea8e63a6591b5feeeda77749d2170211c66a18691
parenta4c6a73aa438d6c44fbe1e5e0c8878051e8c2b54
Relax overly strict assertion

Ever since its birth, ReorderBufferBuildTupleCidHash() has contained an
assertion that a catalog tuple cannot change Cmax after acquiring one.  But
that's wrong: if a subtransaction executes DDL that affects that catalog
tuple, and later aborts and another DDL affects the same tuple, it will
change Cmax.  Relax the assertion to merely verify that the Cmax remains
valid and monotonically increasing, instead.

Add a test that tickles the relevant code.

Diagnosed by, and initial patch submitted by: Arseny Sher
Co-authored-by: Arseny Sher
Discussion: https://postgr.es/m/874l9p8hyw.fsf@ars-thinkpad
contrib/test_decoding/expected/ddl.out
contrib/test_decoding/sql/ddl.sql
src/backend/replication/logical/reorderbuffer.c