]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usbnet: ipheth: remove extraneous rx URB length check
authorFoster Snowhill <forst@pen.gy>
Tue, 6 Aug 2024 17:28:06 +0000 (19:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Sep 2024 17:24:04 +0000 (19:24 +0200)
commitc2fb33a7fed5d88f0c446b6136fe491affbbb8bc
tree867b1a288b7d4bb606cbf98dfd387e0fdedaed64
parent78bce66914dba6fb7a589dd8f3aa3a42c0f78248
usbnet: ipheth: remove extraneous rx URB length check

[ Upstream commit 655b46d7a39ac6f049698b27c1568c0f7ff85d1e ]

Rx URB length was already checked in ipheth_rcvbulk_callback_legacy()
and ipheth_rcvbulk_callback_ncm(), depending on the current mode.
The check in ipheth_rcvbulk_callback() was thus mostly a duplicate.

The only place in ipheth_rcvbulk_callback() where we care about the URB
length is for the initial control frame. These frames are always 4 bytes
long. This has been checked as far back as iOS 4.2.1 on iPhone 3G.

Remove the extraneous URB length check. For control frames, check for
the specific 4-byte length instead.

Signed-off-by: Foster Snowhill <forst@pen.gy>
Tested-by: Georgi Valkov <gvalkov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/usb/ipheth.c