]> git.ipfire.org Git - thirdparty/systemd.git/commit
core/service: do not propagate reload for combined RELOADING=1 + READY=1 when notify...
authorMike Yuan <me@yhndnzj.com>
Wed, 26 Feb 2025 14:02:58 +0000 (15:02 +0100)
committerLuca Boccassi <luca.boccassi@gmail.com>
Wed, 26 Feb 2025 23:41:33 +0000 (23:41 +0000)
commitc337a1301f2de4105fc8023e45db20238c6a895a
tree5d943cc99f3e38c6c8dff4ace4e9523dcdc81e20
parentecf85d8389be08e583971d7664a0cc8094139b7e
core/service: do not propagate reload for combined RELOADING=1 + READY=1 when notify-reload

Follow-up for 3bd28bf721dc70722ff1c675026ed0b44ad968a3

SERVICE_RELOAD_SIGNAL state can only be reached via explicit reload jobs,
and we have a clear distinction between that and plain RELOADING=1
notifications, the latter of which is issued by clients doing reload
outside of our job engine. I.e. upon SERVICE_RELOAD_SIGNAL + RELOADING=1
we don't propagate reload jobs again, since that's done during transaction
construction stage already. The handling of combined RELOADING=1 + READY=1
so far is bogus however, as it tries to propagate duplicate reload jobs.
Amend this by following the logic for standalone RELOADING=1.
src/core/service.c