]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipvs: rerouting to local clients is not needed anymore
authorJulian Anastasov <ja@ssi.bg>
Tue, 10 Mar 2015 13:27:05 +0000 (14:27 +0100)
committerJiri Slaby <jslaby@suse.cz>
Tue, 10 Mar 2015 16:21:38 +0000 (17:21 +0100)
commitc34a4c75777ab9354db9c2d2eb234ce87e45f0bf
tree8b5a8041ff8c23439072bc937ad6a54c499c09d0
parent43ef6dfb1464ed5d2a8e2473b6ad405feb10e2ca
ipvs: rerouting to local clients is not needed anymore

[ upstream commit 579eb62ac35845686a7c4286c0a820b4eb1f96aa ]

commit f5a41847acc5 ("ipvs: move ip_route_me_harder for ICMP")
from 2.6.37 introduced ip_route_me_harder() call for responses to
local clients, so that we can provide valid rt_src after SNAT.
It was used by TCP to provide valid daddr for ip_send_reply().
After commit 0a5ebb8000c5 ("ipv4: Pass explicit daddr arg to
ip_send_reply()." from 3.0 this rerouting is not needed anymore
and should be avoided, especially in LOCAL_IN.

Fixes 3.12.33 crash in xfrm reported by Florian Wiessner:
"3.12.33 - BUG xfrm_selector_match+0x25/0x2f6"

Cc: <stable@vger.kernel.org> # 3.10.x
Cc: <stable@vger.kernel.org> # 3.12.x
Cc: <stable@vger.kernel.org> # 3.14.x
Cc: <stable@vger.kernel.org> # 3.18.x
Reported-by: Smart Weblications GmbH - Florian Wiessner <f.wiessner@smart-weblications.de>
Tested-by: Smart Weblications GmbH - Florian Wiessner <f.wiessner@smart-weblications.de>
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/netfilter/ipvs/ip_vs_core.c