]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
team: don't traverse port list using rcu in team_set_mac_address
authorJiri Pirko <jiri@resnulli.us>
Wed, 4 Mar 2015 07:36:31 +0000 (08:36 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Sat, 14 Mar 2015 19:37:14 +0000 (15:37 -0400)
commitc3b2b0df736920de3a188642d5d88e246ba780e0
tree3e795936b8f4b2bc49cad8f415a12e87a7f5954d
parentf009d6b5ebf8c31b89a71485e8d69819f69dbc3b
team: don't traverse port list using rcu in team_set_mac_address

[ Upstream commit 9215f437b85da339a7dfe3db6e288637406f88b2 ]

Currently the list is traversed using rcu variant. That is not correct
since dev_set_mac_address can be called which eventually calls
rtmsg_ifinfo_build_skb and there, skb allocation can sleep. So fix this
by remove the rcu usage here.

Fixes: 3d249d4ca7 "net: introduce ethernet teaming device"
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/net/team/team.c