]> git.ipfire.org Git - thirdparty/linux.git/commit
serial: sh-sci: Check that the DMA cookie is valid
authorClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Wed, 17 Dec 2025 13:57:59 +0000 (15:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Dec 2025 10:54:00 +0000 (11:54 +0100)
commitc3ca8a0aac832fe8047608bb2ae2cca314c6d717
tree7b761560f2c789323194aa080c3e14350845f8e7
parentf54151148b969fb4b62bec8093d255306d20df30
serial: sh-sci: Check that the DMA cookie is valid

The driver updates struct sci_port::tx_cookie to zero right before the TX
work is scheduled, or to -EINVAL when DMA is disabled.
dma_async_is_complete(), called through dma_cookie_status() (and possibly
through dmaengine_tx_status()), considers cookies valid only if they have
values greater than or equal to 1.

Passing zero or -EINVAL to dmaengine_tx_status() before any TX DMA
transfer has started leads to an incorrect TX status being reported, as the
cookie is invalid for the DMA subsystem. This may cause long wait times
when the serial device is opened for configuration before any TX activity
has occurred.

Check that the TX cookie is valid before passing it to
dmaengine_tx_status().

Fixes: 7cc0e0a43a91 ("serial: sh-sci: Check if TX data was written to device in .tx_empty()")
Cc: stable <stable@kernel.org>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://patch.msgid.link/20251217135759.402015-1-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c