]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
perf: arm_pmuv3: Don't use PMCCNTR_EL0 on SMT cores
authorYicong Yang <yangyicong@hisilicon.com>
Mon, 22 Sep 2025 03:30:10 +0000 (11:30 +0800)
committerWill Deacon <will@kernel.org>
Mon, 3 Nov 2025 13:28:48 +0000 (13:28 +0000)
commitc3d78c34ad009a7cce57ae5b5c93e1bd03bb31a3
treeb53356567ab120fabf91d9cdb84f70f4a50a04f7
parent3a8660878839faadb4f1a6dd72c3179c1df56787
perf: arm_pmuv3: Don't use PMCCNTR_EL0 on SMT cores

CPU_CYCLES is expected to count the logical CPU (PE) clock. Currently it's
preferred to use PMCCNTR_EL0 for counting CPU_CYCLES, but it'll count
processor clock rather than the PE clock (ARM DDI0487 L.b D13.1.3) if
one of the SMT siblings is not idle on a multi-threaded implementation.
So don't use it on SMT cores.

Introduce topology_core_has_smt() for knowing the SMT implementation and
cached it in arm_pmu::has_smt during allocation.

When counting cycles on SMT CPU 2-3 and CPU 3 is idle, without this
patch we'll get:
[root@client1 tmp]# perf stat -e cycles -A -C 2-3 -- stress-ng -c 1
--taskset 2 --timeout 1
[...]
 Performance counter stats for 'CPU(s) 2-3':

CPU2           2880457316      cycles
CPU3           2880459810      cycles
       1.254688470 seconds time elapsed

With this patch the idle state of CPU3 is observed as expected:
[root@client1 ~]#  perf stat -e cycles -A -C 2-3 -- stress-ng -c 1
--taskset 2 --timeout 1
[...]
 Performance counter stats for 'CPU(s) 2-3':

CPU2           2558580492      cycles
CPU3               305749      cycles
       1.113626410 seconds time elapsed

Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/arm_pmu.c
drivers/perf/arm_pmuv3.c
include/linux/arch_topology.h
include/linux/perf/arm_pmu.h