]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sh: intc: Fix use-after-free bug in register_intc_controller()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 23 Oct 2024 08:41:59 +0000 (11:41 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:51:21 +0000 (19:51 +0100)
commitc3f4f4547fb291982f5ef56c048277c4d5ccc4e4
treecf4c18dc629fdb8b8194d8c7d095ddaf960a666b
parentfe6cbf0b2ac3cf4e21824a44eaa336564ed5e960
sh: intc: Fix use-after-free bug in register_intc_controller()

[ Upstream commit 63e72e551942642c48456a4134975136cdcb9b3c ]

In the error handling for this function, d is freed without ever
removing it from intc_list which would lead to a use after free.
To fix this, let's only add it to the list after everything has
succeeded.

Fixes: 2dcec7a988a1 ("sh: intc: set_irq_wake() support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/sh/intc/core.c