]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
phy: core: don't require set_mode() callback for phy_get_mode() to work
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sun, 9 Feb 2025 12:31:45 +0000 (14:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:38:02 +0000 (14:38 +0200)
commitc48f7855988f2151fee9ee3f672addef47b06940
tree0d542325002f01b376d0ffb5fd1199947dd9d661
parentc8128c04193b94f1dc5e0c25cda70be2b0ac5a94
phy: core: don't require set_mode() callback for phy_get_mode() to work

[ Upstream commit d58c04e305afbaa9dda7969151f06c4efe2c98b0 ]

As reported by Damon Ding, the phy_get_mode() call doesn't work as
expected unless the PHY driver has a .set_mode() call. This prompts PHY
drivers to have empty stubs for .set_mode() for the sake of being able
to get the mode.

Make .set_mode() callback truly optional and update PHY's mode even if
it there is none.

Cc: Damon Ding <damon.ding@rock-chips.com>
Link: https://lore.kernel.org/r/96f8310f-93f1-4bcb-8637-137e1159ff83@rock-chips.com
Tested-by: Damon Ding <damon.ding@rock-chips.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250209-phy-fix-set-moe-v2-1-76e248503856@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/phy/phy-core.c