]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
mptcp: use MPJoinSynAckHMacFailure for SynAck HMAC failure
authorShardul Bankar <shardul.b@mpiricsoftware.com>
Fri, 1 May 2026 19:35:34 +0000 (21:35 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 5 May 2026 02:20:50 +0000 (19:20 -0700)
commitc4a99a921949cddc590b22bb14eeb23dffcc3ba6
treebfa45c88a07acd6f8473f84afc5a26bfb6152e4f
parent059b7dbd20a6f0c539a45ddff1573cb8946685b5
mptcp: use MPJoinSynAckHMacFailure for SynAck HMAC failure

In subflow_finish_connect(), HMAC validation of the server's HMAC
in SYN/ACK + MP_JOIN increments MPTCP_MIB_JOINACKMAC ("HMAC was
wrong on ACK + MP_JOIN") on failure. The function processes the
SYN/ACK, not the ACK; the matching MPTCP_MIB_JOINSYNACKMAC counter
("HMAC was wrong on SYN/ACK + MP_JOIN") exists but is not
incremented anywhere in the tree.

The mirror site on the server, subflow_syn_recv_sock(), already
uses JOINACKMAC correctly for ACK HMAC failure. Use JOINSYNACKMAC
at the SYN/ACK validation site so each counter reflects the packet
whose HMAC actually failed.

Suggested-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Fixes: fc518953bc9c ("mptcp: add and use MIB counter infrastructure")
Cc: stable@vger.kernel.org
Signed-off-by: Shardul Bankar <shardul.b@mpiricsoftware.com>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20260501-net-mptcp-misc-fixes-7-1-rc3-v1-1-b70118df778e@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/subflow.c