]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME
authorAndy Lutomirski <luto@amacapital.net>
Fri, 21 Nov 2014 21:26:07 +0000 (13:26 -0800)
committerJiri Slaby <jslaby@suse.cz>
Sat, 6 Dec 2014 14:14:50 +0000 (15:14 +0100)
commitc50db3a5b930ef107cf6df611e729032e69de350
treefa7658a88b2f2e7d4ba73a83aef29307346ade65
parent868b19cb0314da9725ec108ec6abb082965cd0c2
uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME

commit 82975bc6a6df743b9a01810fb32cb65d0ec5d60b upstream.

x86 call do_notify_resume on paranoid returns if TIF_UPROBE is set but
not on non-paranoid returns.  I suspect that this is a mistake and that
the code only works because int3 is paranoid.

Setting _TIF_NOTIFY_RESUME in the uprobe code was probably a workaround
for the x86 bug.  With that bug fixed, we can remove _TIF_NOTIFY_RESUME
from the uprobes code.

Reported-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
arch/x86/include/asm/thread_info.h
kernel/events/uprobes.c