]> git.ipfire.org Git - thirdparty/openvpn.git/commit
ssl.c: fix use of openvpn_run_script()'s return value
authorFabian Knittel <fabian.knittel@avona.com>
Tue, 4 May 2010 14:21:47 +0000 (16:21 +0200)
committerDavid Sommerseth <dazo@users.sourceforge.net>
Tue, 4 May 2010 21:12:15 +0000 (23:12 +0200)
commitc5b7923a2b0a94d702e1dad59438f7ee75971d3b
treec08cf576c35f56433b3ca8b9c56ece194c12ede1
parent339f2a4d4b487afa53fa99d72c35b16f31e417d3
ssl.c: fix use of openvpn_run_script()'s return value

This patch fixes two bugs introduced in

    commit 339f2a4d4b487afa53fa99d72c35b16f31e417d3
    Author: David Sommerseth <dazo@users.sourceforge.net>
    Date:   Thu Apr 29 23:35:45 2010 +0200

David's patch replaced openvpn_execve() with openvpn_run_script() in two places,
but didn't adjust the return value handling.  openvpn_run_script() returns true
or false, while openvpn_execve() returns the program's exit code.

Without the fix, the --tls-verify script and the --auth-user-pass-verify
script fail to run.  (I noticed the latter, but haven't actually tested the
former.)

The return value handling is fine for the other places where
openvpn_run_script() is used, because those places previously used
openvpn_execve_check() (notice the "_check" suffix).

Signed-off-by: Fabian Knittel <fabian.knittel@avona.com>
Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
Acked-by: David Sommerseth <dazo@users.sourceforge.net>
ssl.c