]> git.ipfire.org Git - thirdparty/util-linux.git/commit
login: use TCSANOW to remove HUPCL
authorKarel Zak <kzak@redhat.com>
Wed, 5 Jun 2013 12:31:00 +0000 (14:31 +0200)
committerKarel Zak <kzak@redhat.com>
Wed, 5 Jun 2013 12:43:21 +0000 (14:43 +0200)
commitc5bb244ea3f9fe8d4dbe07080ec811e232629ff8
tree35e1a6e6f8db2df37da0154fd6b71b16f1358708
parentb8b8e76806387f4a8f1b8913159d690258a43c86
login: use TCSANOW to remove HUPCL

Fedora 19, kernel 3.9, systemd 204, telnetd with socket activation.

login(1) code:

        ttt.c_cflag &= ~HUPCL;
        tcsetattr(0, TCSAFLUSH, &ttt);

        close(STDIN_FILENO);
        close(STDOUT_FILENO);
        close(STDERR_FILENO);

        signal(SIGHUP, SIG_IGN);        /* so vhangup() wont kill us */
        vhangup();
        signal(SIGHUP, SIG_DFL);

strace :

ioctl(0, SNDCTL_TMR_CONTINUE or SNDRV_TIMER_IOCTL_GPARAMS or TCSETSF, {B9600 opost isig icanon echo ...}) = 0
close(0)                                = 0
close(1)                                = 0
close(2)                                = 0
--- SIGHUP {si_signo=SIGHUP, si_code=SI_KERNEL} ---
--- SIGTERM {si_signo=SIGTERM, si_code=SI_USER, si_pid=1, si_uid=0} ---
+++ killed by SIGTERM +++

It seems we get SIGHUP (and SIGTERM from systemd) before vhangup().
The problem occur sometimes.

I guess it's because TCSAFLUSH is not applied immediately, so it would
be probably better to use TCSANOW to make the code more robust.

References: https://bugzilla.redhat.com/show_bug.cgi?id=962145
Signed-off-by: Karel Zak <kzak@redhat.com>
login-utils/login.c