]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
block: add cond_resched() to potentially long running ioctl discard loop
authorJens Axboe <axboe@fb.com>
Wed, 12 Feb 2014 16:34:01 +0000 (09:34 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Feb 2014 18:32:46 +0000 (10:32 -0800)
commitc5bdb3a52d40d1ef3b3f6fb3617d20bb47cee46c
treec66bd8cb89b5f9b7b89955caf67814eebbf19861
parente7a95613d77dcbcbefe99b465c6488550caf2c85
block: add cond_resched() to potentially long running ioctl discard loop

commit c8123f8c9cb517403b51aa41c3c46ff5e10b2c17 upstream.

When mkfs issues a full device discard and the device only
supports discards of a smallish size, we can loop in
blkdev_issue_discard() for a long time. If preempt isn't enabled,
this can turn into a softlock situation and the kernel will
start complaining.

Add an explicit cond_resched() at the end of the loop to avoid
that.

Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/blk-lib.c