]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
selftests: mptcp: join: fix local endp not being tracked
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Tue, 27 Jan 2026 19:27:27 +0000 (20:27 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Jan 2026 04:58:51 +0000 (20:58 -0800)
commitc5d5ecf21fdd9ce91e6116feb3aa83cee73352cc
tree388bd85ffee3d37f076a5a62503b3fe8902cd2f9
parent2ef9e3a3845d0a20b62b01f5b731debd0364688d
selftests: mptcp: join: fix local endp not being tracked

When running this mptcp_join.sh selftest on older kernel versions not
supporting local endpoints tracking, this test fails because 3 MP_JOIN
ACKs have been received, while only 2 were expected.

It is not clear why only 2 MP_JOIN ACKs were expected on old kernel
versions, while 3 MP_JOIN SYN and SYN+ACK were expected. When testing on
the v5.15.197 kernel, 3 MP_JOIN ACKs are seen, which is also what is
expected in the selftests included in this kernel version, see commit
f4480eaad489 ("selftests: mptcp: add missing join check").

Switch the expected MP_JOIN ACKs to 3. While at it, move this
chk_join_nr helper out of the special condition for older kernel
versions as it is now the same as with more recent ones. Also, invert
the condition to be more logical: what's expected on newer kernel
versions having such helper first.

Fixes: d4c81bbb8600 ("selftests: mptcp: join: support local endpoint being tracked or not")
Cc: stable@vger.kernel.org
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20260127-net-mptcp-dup-nl-events-v1-5-7f71e1bc4feb@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_join.sh