]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/nouveau: fix error path in nvkm_gsp_fwsec_v2
authorTimur Tabi <ttabi@nvidia.com>
Wed, 13 Aug 2025 00:10:02 +0000 (19:10 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Sep 2025 13:31:55 +0000 (15:31 +0200)
commitc5e42567724ee99d45e1eb98bb4b9c04e2294d26
tree827cea48cd2ac6bdabddac96b487117be215ec23
parent2de53596eeb201c7c9b8ffd72d31ec0ae5bf7aa2
drm/nouveau: fix error path in nvkm_gsp_fwsec_v2

commit 66e82b6e0a28d4970383e1ee5d60f431001128cd upstream.

Function nvkm_gsp_fwsec_v2() sets 'ret' if the kmemdup() call fails, but
it never uses or returns 'ret' after that point.  We always need to release
the firmware regardless, so do that and then check for error.

Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-RM")
Cc: stable@vger.kernel.org # v6.7+
Signed-off-by: Timur Tabi <ttabi@nvidia.com>
Link: https://lore.kernel.org/r/20250813001004.2986092-1-ttabi@nvidia.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/fwsec.c