]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-33604: Raise TypeError on missing hmac arg. (GH-16805)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 18 Oct 2019 03:48:42 +0000 (20:48 -0700)
committerGitHub <noreply@github.com>
Fri, 18 Oct 2019 03:48:42 +0000 (20:48 -0700)
commitc615db608dbb36a5d10188f7d265dcec7bfcc3cf
tree42490a227baced6cca5ef4f871926413967a564a
parent7773d391f8261a97af502ecfa74a2a588ee05f36
bpo-33604: Raise TypeError on missing hmac arg. (GH-16805)

Also updates the documentation to clarify the situation surrounding
the digestmod parameter that is required despite its position in the
argument list as of 3.8.0 as well as removing old python2 era
references to "binary strings".

We indavertently had this raise ValueError in 3.8.0 for the missing
arg.  This is not considered an API change as no reasonable code would
be catching this missing argument error in order to handle it.
(cherry picked from commit f33c57d5c780da1500619f548585792bb5b750ee)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Doc/library/hmac.rst
Lib/hmac.py
Lib/test/test_hmac.py
Misc/NEWS.d/next/Library/2019-10-15-09-47-40.bpo-33604.J12cWT.rst [new file with mode: 0644]