]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gfs2: fix gfs2_find_jhead that returns uninitialized jhead with seq 0
authorAbhi Das <adas@redhat.com>
Tue, 4 Feb 2020 20:14:56 +0000 (14:14 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Feb 2020 12:35:35 +0000 (04:35 -0800)
commitc61b93fae603ef212e95c6071ca4db9afe3ab782
tree16f0d9f192c592f12077a8176524349fe8267750
parent65afa6958134ae578f2f5867fe5c51952a09f0ff
gfs2: fix gfs2_find_jhead that returns uninitialized jhead with seq 0

commit 7582026f6f3588ecebd281965c8a71aff6fb6158 upstream.

When the first log header in a journal happens to have a sequence
number of 0, a bug in gfs2_find_jhead() causes it to prematurely exit,
and return an uninitialized jhead with seq 0. This can cause failures
in the caller. For instance, a mount fails in one test case.

The correct behavior is for it to continue searching through the journal
to find the correct journal head with the highest sequence number.

Fixes: f4686c26ecc3 ("gfs2: read journal in large chunks")
Cc: stable@vger.kernel.org # v5.2+
Signed-off-by: Abhi Das <adas@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/gfs2/lops.c