]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
MIPS: Use address-of operator on section symbols
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 5 Jan 2021 20:18:27 +0000 (13:18 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 15 May 2022 17:41:57 +0000 (19:41 +0200)
commitc6648430f9c37e75f69ab5ec30489a33ca8ee580
tree24d5bf15cb32af5338d97dfec47ce6de6ce91674
parent89ef890678b100bbd345dd0c2facc24ee21a770a
MIPS: Use address-of operator on section symbols

commit d422c6c0644bccbb1ebeefffa51f35cec3019517 upstream.

When building xway_defconfig with clang:

arch/mips/lantiq/prom.c:82:23: error: array comparison always evaluates
to true [-Werror,-Wtautological-compare]
        else if (__dtb_start != __dtb_end)
                             ^
1 error generated.

These are not true arrays, they are linker defined symbols, which are
just addresses. Using the address of operator silences the warning
and does not change the resulting assembly with either clang/ld.lld
or gcc/ld (tested with diff + objdump -Dr). Do the same thing across
the entire MIPS subsystem to ensure there are no more warnings around
this type of comparison.

Link: https://github.com/ClangBuiltLinux/linux/issues/1232
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/mips/bmips/setup.c
arch/mips/lantiq/prom.c
arch/mips/pic32/pic32mzda/init.c
arch/mips/ralink/of.c