]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: greybus: Fix uninitialized scalar variable
authorOscar Carter <oscar.carter@gmx.com>
Sun, 10 May 2020 10:14:26 +0000 (12:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 May 2020 15:37:42 +0000 (17:37 +0200)
commitc6d40a80584697251846b08366cecb2a9e9d032c
treed26ff3bf08028d1eaa3879384c056793ffb59168
parent7f08947a5420678a3f557bb5ddec5a221f78eaaa
staging: greybus: Fix uninitialized scalar variable

commit 34625c1931f8204c234c532b446b9f53c69f4b68 upstream.

In the "gb_tty_set_termios" function the "newline" variable is declared
but not initialized. So the "flow_control" member is not initialized and
the OR / AND operations with itself results in an undefined value in
this member.

The purpose of the code is to set the flow control type, so remove the
OR / AND self operator and set the value directly.

Addresses-Coverity-ID: 1374016 ("Uninitialized scalar variable")
Fixes: e55c25206d5c9 ("greybus: uart: Handle CRTSCTS flag in termios")
Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200510101426.23631-1-oscar.carter@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/uart.c