]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: light: opt3001: fix mutex unlock race
authorDavid Frey <dpfrey@gmail.com>
Thu, 19 Sep 2019 22:54:18 +0000 (15:54 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2019 20:42:42 +0000 (13:42 -0700)
commitc6fd435d9c4cd5c4380569dd0a654f19107e5bcb
tree5307ad015da992ef739614930d17ea0987e461fa
parentb78ad0e5f5cfde9bf0bf66a6ce2088bc6e13eca3
iio: light: opt3001: fix mutex unlock race

commit 82f3015635249a8c8c45bac303fd84905066f04f upstream.

When an end-of-conversion interrupt is received after performing a
single-shot reading of the light sensor, the driver was waking up the
result ready queue before checking opt->ok_to_ignore_lock to determine
if it should unlock the mutex. The problem occurred in the case where
the other thread woke up and changed the value of opt->ok_to_ignore_lock
to false prior to the interrupt thread performing its read of the
variable. In this case, the mutex would be unlocked twice.

Signed-off-by: David Frey <dpfrey@gmail.com>
Reviewed-by: Andreas Dannenberg <dannenberg@ti.com>
Fixes: 94a9b7b1809f ("iio: light: add support for TI's opt3001 light sensor")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/light/opt3001.c