]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: rockchip: Fix order of rockchip_pci_core_rsts
authorJensen Huang <jensenhuang@friendlyarm.com>
Fri, 28 Mar 2025 10:58:22 +0000 (18:58 +0800)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Sat, 19 Apr 2025 13:47:02 +0000 (19:17 +0530)
commitc7540e5423d7f588c7210a9941ceb6a836963ccc
treeda1a52303d61735e7005df9c21de78ebf174f45e
parent0af2f6be1b4281385b618cb86ad946eded089ac8
PCI: rockchip: Fix order of rockchip_pci_core_rsts

The order of rockchip_pci_core_rsts introduced in the offending commit
followed the previous comment that warned not to reorder them. But the
commit failed to take into account that reset_control_bulk_deassert()
deasserts the resets in reverse order. So this leads to the link getting
downgraded to 2.5 GT/s.

Hence, restore the deassert order and also add back the comments for
rockchip_pci_core_rsts.

Tested on NanoPC-T4 with Samsung 970 Pro.

Fixes: 18715931a5c0 ("PCI: rockchip: Simplify reset control handling by using reset_control_bulk*() function")
Signed-off-by: Jensen Huang <jensenhuang@friendlyarm.com>
[mani: reworded the commit message and the comment above rockchip_pci_core_rsts]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>
Link: https://patch.msgid.link/20250328105822.3946767-1-jensenhuang@friendlyarm.com
drivers/pci/controller/pcie-rockchip.h