]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: magnetometer: fix if () scoped_guard() formatting
authorStephen Rothwell <sfr@canb.auug.org.au>
Fri, 8 Nov 2024 15:41:27 +0000 (16:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 19:03:38 +0000 (20:03 +0100)
commitc7559dc2047e655eaa7e9be78bc7efab956463b9
tree9710fafcec148809dcabf9cb09e7d0e9f0cb93d7
parentff599ad2d2b809cd6a57bf3fdb2e5f93feea8f0e
iio: magnetometer: fix if () scoped_guard() formatting

commit 9a884bdb6e9560c6da44052d5248e89d78c983a6 upstream.

Add mising braces after an if condition that contains scoped_guard().

This style is both preferred and necessary here, to fix warning after
scoped_guard() change in commit fcc22ac5baf0 ("cleanup: Adjust
scoped_guard() macros to avoid potential warning") to have if-else inside
of the macro. Current (no braces) use in af8133j_set_scale() yields
the following warnings:
af8133j.c:315:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
af8133j.c:316:3: warning: add explicit braces to avoid dangling else [-Wdangling-else]

Fixes: fcc22ac5baf0 ("cleanup: Adjust scoped_guard() macros to avoid potential warning")
Closes: https://lore.kernel.org/oe-kbuild-all/202409270848.tTpyEAR7-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20241108154258.21411-1-przemyslaw.kitszel@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/magnetometer/af8133j.c