]> git.ipfire.org Git - thirdparty/patchwork.git/commit
Add index for patchwork_comment (submission_id,date)
authorStewart Smith <stewart@linux.ibm.com>
Fri, 10 Aug 2018 08:00:58 +0000 (18:00 +1000)
committerStephen Finucane <stephen@that.guru>
Thu, 6 Sep 2018 19:36:21 +0000 (20:36 +0100)
commitc757b305b12c3574f0cc283a66d7f59efa5e34ed
tree081b89c78347394c02dcc1e186883a5143b4d27e
parentcf0826376911b22c846881e3f455b9592d7bda48
Add index for patchwork_comment (submission_id,date)

This (at least theoretically) should speed up displaying comments
on patches/cover letters. It's an index that will return rows
in-order for the query that we always do ("give me the comments
on this submission in date order"), rather than having to have
the database server do a sort for us.

I haven't been able to benchmark something locally that shows
this is an actual improvement, but I don't have as large data
set as various production instances. The query plan does look
a bit nicer though. Although the benefit of index maintenance
versus how long it takes to sort things is a good question.

Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
[stephenfin: Regenerate migrations per addition of 0027 in earlier
 patch]
Signed-off-by: Stephen Finucane <stephen@that.guru>
patchwork/migrations/0028_add_comment_date_index.py [new file with mode: 0644]
patchwork/models.py