]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
perf/imx_ddr: don't enable counter0 if none of 4 counters are used
authorXu Yang <xu.yang_2@nxp.com>
Fri, 11 Aug 2023 01:54:38 +0000 (09:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:22:31 +0000 (12:22 +0200)
commitc7802ff51adce9ae2e8392b926943342549de38c
tree878380f96b83f20ed0a3453d30d778d8b191531f
parent0a872a0521c8592b517406f5dce6c2ba7e19eac0
perf/imx_ddr: don't enable counter0 if none of 4 counters are used

[ Upstream commit f4e2bd91ddf5e8543cbe7ad80b3fba3d2dc63fa3 ]

In current driver, counter0 will be enabled after ddr_perf_pmu_enable()
is called even though none of the 4 counters are used. This will cause
counter0 continue to count until ddr_perf_pmu_disabled() is called. If
pmu is not disabled all the time, the pmu interrupt will be asserted
from time to time due to counter0 will overflow and irq handler will
clear it. It's not an expected behavior. This patch will not enable
counter0 if none of 4 counters are used.

Fixes: 9a66d36cc7ac ("drivers/perf: imx_ddr: Add DDR performance counter support to perf")
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20230811015438.1999307-2-xu.yang_2@nxp.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/perf/fsl_imx8_ddr_perf.c