]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
projects / thirdparty / xfsprogs-dev.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1bec3a6) | patch
xfs_repair: fix left-shift overflows
authorEric Sandeen <sandeen@sandeen.net>
Wed, 14 Oct 2015 00:04:23 +0000 (11:04 +1100)
committerDave Chinner <david@fromorbit.com>
Wed, 14 Oct 2015 00:04:23 +0000 (11:04 +1100)
commitc782bf02db94b08c770dce2c2ecb9762cd4a510f
tree0a4f5708cf7c45eebaf09bbe80989800d686d6detree | snapshot
parent1bec3a62f642eedbb60b62be128cb5b4a65ba985commit | diff
xfs_repair: fix left-shift overflows

pmask in struct parent_list is a __uint64_t, but in some places
we populated it with "1LL << shift" where shift could be up
to 63; this really needs to be a 1ULL type for this to be correct.

Also spotted by libubsan...

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
repair/incore_ino.c diff | blob | blame | history
repair/prefetch.c diff | blob | blame | history
Unnamed repository; edit this file 'description' to name the repository.