]> git.ipfire.org Git - thirdparty/linux.git/commit
net: dsa: microchip: Fix a link check in ksz9477_pcs_read()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 31 Oct 2025 13:05:01 +0000 (16:05 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 6 Nov 2025 01:58:51 +0000 (17:58 -0800)
commitc79a022524577e486220bc9627ccebc706148c1f
treeb88e2223f06bbabe688453768958f75f1f818e65
parentdfb073d32cac28cdb597d16d1e0589b25c841661
net: dsa: microchip: Fix a link check in ksz9477_pcs_read()

The BMSR_LSTATUS define is 0x4 but the "p->phydev.link" variable
is a 1 bit bitfield in a u32.  Since 4 doesn't fit in 0-1 range
it means that ".link" is always set to false.  Add a !! to fix
this.

[Jakub: According to Maxime the phydev struct isn't really
used and we should consider removing it completely. So not
treating this as a fix.]

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aQSz_euUg0Ja8ZaH@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/microchip/ksz9477.c