]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: ucsi: huawei_gaokun: move typec_altmode off stack
authorArnd Bergmann <arnd@arndb.de>
Thu, 18 Jun 2026 14:33:14 +0000 (16:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Jul 2026 12:14:37 +0000 (14:14 +0200)
commitc7eaea5c6eeb391d445583fa6419c957ca74a86b
treeab63d49ff249035d890626b3acdf50afb1e0e2cf
parente8da46d99d3710106e7c44db14566bf9b57386b5
usb: ucsi: huawei_gaokun: move typec_altmode off stack

The typec_altmode structure contains a 'struct device' object
that cannot be allocated on the stack because of its size, even
when ignoring the lifetime rules:

drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c:326:13: error: stack frame size (1456) exceeds limit (1280) in 'gaokun_ucsi_usb_notify_ind' [-Werror,-Wframe-larger-than]
  326 | static void gaokun_ucsi_usb_notify_ind(struct gaokun_ucsi *uec)

Since the altmode is always associated with a port here, move
it into the port object and avoid at least the stack allocation
issue.

Fixes: 1c2b66a7d725 ("usb: ucsi: huawei_gaokun: support mode switching")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Pengyu Luo <mitltlatltl@gmail.com>
Link: https://patch.msgid.link/20260618143341.1900221-1-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/ucsi/ucsi_huawei_gaokun.c