]> git.ipfire.org Git - thirdparty/openwrt.git/commit
treewide: add explicit default variant 21355/head
authorEric Fahlgren <ericfahlgren@gmail.com>
Fri, 2 Jan 2026 02:02:30 +0000 (18:02 -0800)
committerRobert Marko <robimarko@gmail.com>
Fri, 2 Jan 2026 17:11:04 +0000 (18:11 +0100)
commitc80bae3c1893216dc7d9965afb44eff23e3a8a23
tree6d1cd566465764d2ddb3635a6e2857ca2d30c880
parent038546e2e5606d201134a9165fb6b775bb4b8021
treewide: add explicit default variant

Some packages with variants did not specify the default among the
alternatives, so were left without any apk 'provider_priority'
for that package.  This caused the apk solver to select the wrong
variant, silently changing the requested package list.

Notable among these were busybox, procd and the hostapd/wpad suite.
This behavior presented in the imagebuilders when creating the
image as follows, silently replacing packages even when explicitly
requested:

    $ make image PACKAGES=busybox
    ...
    ( 14/148) Installing busybox-selinux (1.37.0-r6)
    ...

We add 'DEFAULT_VARIANT:=1' to the packages that were missing one,
providing apk with sufficient information to choose the correct
package.

See link below for further examples and discussion.

Link: https://github.com/openwrt/openwrt/pull/21288#issuecomment-3704101422
Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/21358
(cherry picked from commit f4fdb9964a1add146e0efdeba864a6478212a9fa)
Link: https://github.com/openwrt/openwrt/pull/21355
Signed-off-by: Robert Marko <robimarko@gmail.com>
package/network/services/dnsmasq/Makefile
package/network/services/hostapd/Makefile
package/network/utils/ethtool/Makefile
package/system/procd/Makefile
package/system/ucert/Makefile
package/utils/busybox/Makefile
package/utils/f2fs-tools/Makefile