]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: phy: Fix verification of EEE support in phy_init_eee
authorGuenter Roeck <linux@roeck-us.net>
Tue, 17 Feb 2015 17:36:22 +0000 (09:36 -0800)
committerJiri Slaby <jslaby@suse.cz>
Thu, 12 Mar 2015 09:06:26 +0000 (10:06 +0100)
commitc83355ce6fdafb24031c7032ee011ad4d7f2ca9c
treeb4bbaf3450cec3a979e5a246a6e1525ec5873ed7
parenta930d60b78912c6aba1a4c17aab752850b4883bd
net: phy: Fix verification of EEE support in phy_init_eee

[ Upstream commit 54da5a8be3c1e924c35480eb44c6e9b275f6444e ]

phy_init_eee uses phy_find_setting(phydev->speed, phydev->duplex)
to find a valid entry in the settings array for the given speed
and duplex value. For full duplex 1000baseT, this will return
the first matching entry, which is the entry for 1000baseKX_Full.

If the phy eee does not support 1000baseKX_Full, this entry will not
match, causing phy_init_eee to fail for no good reason.

Fixes: 9a9c56cb34e6 ("net: phy: fix a bug when verify the EEE support")
Fixes: 3e7077067e80c ("phy: Expand phy speed/duplex settings array")
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/net/phy/phy.c