]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: format/parse <vmcoreinfo> as tristate
authorCole Robinson <crobinso@redhat.com>
Tue, 17 Apr 2018 16:34:31 +0000 (12:34 -0400)
committerCole Robinson <crobinso@redhat.com>
Thu, 3 May 2018 20:37:41 +0000 (16:37 -0400)
commitc84be0815680e400c4f1acc00fce4181dda20c66
treea43242f2a06e83bb4f2c104ed0b02c17a67e88df
parent8525b9694e51cc7f3e53164bc0802329471e4d17
conf: format/parse <vmcoreinfo> as tristate

<features><vmcoreinfo/> is a bare boolean XML property. We don't really
use this format anymore and instead prefer tristate <X state=on|off/>
since it's required for modeling on/off/default. If for example future
qemu started enabling vmcoreinfo by default we wouldn't have any way
for the user to turn this off.

Convert it to tristate. For writing XML this is semanticly the same,
<vmcoreinfo/> is processed as <vmcoreinfo state='on'/>.

For apps reading guest XML this is technically an API change,
as they might misinterpret <vmcoreinfo state='off'/>, however this
has only been present in libvirt since 3.10.0 and I don't think any
apps are dependent on this yet

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
docs/formatdomain.html.in
docs/schemas/domaincommon.rng
src/conf/domain_conf.c
tests/qemuxml2xmloutdata/vmcoreinfo.xml