]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: logitech-dj: prevent false errors to be shown
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Fri, 22 Aug 2014 20:16:05 +0000 (16:16 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Oct 2014 21:52:12 +0000 (14:52 -0700)
commitc84e10787d1dc2b5ccdaf7d62f5a00cae90a0adb
treea38cc772468b18b47dad49cfc2beecc0f6fffca2
parent6e4106ec619b16593d66ad6384f6f983d423ee0b
HID: logitech-dj: prevent false errors to be shown

commit 5abfe85c1d4694d5d4bbd13ecc166262b937adf0 upstream.

Commit "HID: logitech: perform bounds checking on device_id early
enough" unfortunately leaks some errors to dmesg which are not real
ones:
- if the report is not a DJ one, then there is not point in checking
  the device_id
- the receiver (index 0) can also receive some notifications which
  can be safely ignored given the current implementation

Move out the test regarding the report_id and also discards
printing errors when the receiver got notified.

Fixes: ad3e14d7c5268c2e24477c6ef54bbdf88add5d36
Reported-and-tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-logitech-dj.c
drivers/hid/hid-logitech-dj.h