]> git.ipfire.org Git - thirdparty/shadow.git/commit
Avoid comparisons of different signs
authorChristian Göttsche <cgzones@googlemail.com>
Tue, 24 Jan 2023 15:05:20 +0000 (16:05 +0100)
committerIker Pedrosa <ikerpedrosam@gmail.com>
Wed, 25 Jan 2023 11:31:17 +0000 (12:31 +0100)
commitc99d8d0a086efb6073417b8c9104fc30a98e72db
tree27538f93390d4984b34825d550d4ff8545cf6710
parent43508ac4763591a5f05b884abeeed934b6748680
Avoid comparisons of different signs

Comparisons if different signedness can result in unexpected results.
Add casts to ensure operants are of the same type.

    gettime.c: In function 'gettime':
    gettime.c:58:26: warning: comparison of integer expressions of different signedness: 'long long unsigned int' and 'time_t' {aka 'long int'} [-Wsign-compare]
       58 |         } else if (epoch > fallback) {
          |                          ^

Cast to time_t, since epoch is less than ULONG_MAX at this point.

    idmapping.c: In function 'write_mapping':
    idmapping.c:202:48: warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
      202 |                 if ((written <= 0) || (written >= (bufsize - (pos - buf)))) {
          |                                                ^~

    newgidmap.c: In function ‘main’:
    newgidmap.c:178:40: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
      178 |         if ((written <= 0) || (written >= sizeof(proc_dir_name))) {
          |                                        ^~
    newuidmap.c: In function ‘main’:
    newuidmap.c:107:40: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
      107 |         if ((written <= 0) || (written >= sizeof(proc_dir_name))) {
          |                                        ^~
libmisc/gettime.c
libmisc/idmapping.c
src/newgidmap.c
src/newuidmap.c