]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
nfc: hci: shdlc: Stop timers and work before freeing context
authorVotokina Victoria <Victoria.Votokina@kaspersky.com>
Tue, 3 Feb 2026 11:31:57 +0000 (14:31 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 6 Feb 2026 02:46:20 +0000 (18:46 -0800)
commitc9efde1e537baed7648a94022b43836a348a074f
tree141ab504ac44019d920bbcc419eb5e3986e254d3
parente1aa5ef892fb4fa9014a25e87b64b97347919d37
nfc: hci: shdlc: Stop timers and work before freeing context

llc_shdlc_deinit() purges SHDLC skb queues and frees the llc_shdlc
structure while its timers and state machine work may still be active.

Timer callbacks can schedule sm_work, and sm_work accesses SHDLC state
and the skb queues. If teardown happens in parallel with a queued/running
work item, it can lead to UAF and other shutdown races.

Stop all SHDLC timers and cancel sm_work synchronously before purging the
queues and freeing the context.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 4a61cd6687fc ("NFC: Add an shdlc llc module to llc core")
Signed-off-by: Votokina Victoria <Victoria.Votokina@kaspersky.com>
Link: https://patch.msgid.link/20260203113158.2008723-1-Victoria.Votokina@kaspersky.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/nfc/hci/llc_shdlc.c