]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id()
authorZeng Chi <zengchi@kylinos.cn>
Fri, 23 Jan 2026 08:57:49 +0000 (16:57 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sun, 25 Jan 2026 22:44:29 +0000 (14:44 -0800)
commitca12c4a155ebf84e9ef29b05ce979bc89364290f
treea98e24a8d38fdc4010cda7c2085f283f2c984b22
parentf0813bcd2d9d97fdbdf2efb9532ab03ae92e99e6
net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id()

The function mlx5_esw_vport_vhca_id() is declared to return bool,
but returns -EOPNOTSUPP (-45), which is an int error code. This
causes a signedness bug as reported by smatch.

This patch fixes this smatch report:
drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:981 mlx5_esw_vport_vhca_id()
warn: signedness bug returning '(-45)'

Fixes: 1baf30426553 ("net/mlx5: E-Switch, Set/Query hca cap via vhca id")
Reviewed-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Zeng Chi <zengchi@kylinos.cn>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20260123085749.1401969-1-zeng_chi911@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/eswitch.h