]> git.ipfire.org Git - thirdparty/linux.git/commit
ntfs3: Restore NULL folio initialization in ntfs_writepages()
authorNathan Chancellor <nathan@kernel.org>
Mon, 5 Jan 2026 19:17:10 +0000 (12:17 -0700)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Fri, 16 Jan 2026 13:18:06 +0000 (14:18 +0100)
commitca1ceddfaa99e91da8b7ac24785b27d400b88309
tree758f67e60ea40c6ac2a4786d270f24b1f1dfad53
parent6b3c83df9a0a61eb7a11beb1cef7ae5c2eb3efb6
ntfs3: Restore NULL folio initialization in ntfs_writepages()

Clang warns (or errors with CONFIG_WERROR=y):

  fs/ntfs3/inode.c:1021:6: error: variable 'folio' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
   1021 |         if (is_resident(ni)) {
        |             ^~~~~~~~~~~~~~~
  fs/ntfs3/inode.c:1024:48: note: uninitialized use occurs here
   1024 |                 while ((folio = writeback_iter(mapping, wbc, folio, &err)))
        |                                                              ^~~~~

folio should be initialized to NULL for the first iteration of
writeback_iter() to start the loop properly. Restore the NULL
initialization of folio that was lost in the recent iomap conversion to
clear up the warning.

Fixes: 099ef9a ("fs/ntfs3: implement iomap-based file operations")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/oe-kbuild-all/202601010644.FIhOXy6Y-lkp@intel.com/
Closes: https://lore.kernel.org/r/202601010513.axd56bks-lkp@intel.com/
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
[almaz.alexandrovich@paragon-software.com: added a few more tags]
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/inode.c